Skip to content

Fix resolve dockerfile name#772

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-eng:mainfrom
thegreyd:fix_resolve_dockerfile_name
Jul 12, 2024
Merged

Fix resolve dockerfile name#772
openshift-merge-bot[bot] merged 1 commit intoopenshift-eng:mainfrom
thegreyd:fix_resolve_dockerfile_name

Conversation

@thegreyd
Copy link
Contributor

@thegreyd thegreyd commented Jul 12, 2024 •
edited
Loading

Right now images:streams prs open breaks because of this.
We don't need the absolute path of Dockerfile but just the filename,
so we do not need to pass in source_path.

@thegreyd thegreyd force-pushed the fix_resolve_dockerfile_name branch from e6ea387 to 38f5425 Compare July 12, 2024 15:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

@thegreyd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 38f5425 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thegreyd thegreyd requested a review from ashwindasr July 12, 2024 15:45
@thegreyd thegreyd mentioned this pull request Jul 12, 2024
Closed
@ashwindasr
Copy link
Contributor

ashwindasr commented Jul 12, 2024

/lgtm

test rebase succeeded as well, on local

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
@thegreyd
Copy link
Contributor Author

thegreyd commented Jul 12, 2024

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thegreyd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6e332ce into openshift-eng:main Jul 12, 2024
This was referenced Jul 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashwindasr ashwindasr Awaiting requested review from ashwindasr

Assignees

@ashwindasr ashwindasr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thegreyd @ashwindasr